Skip to content

set hoist-workspace-packages=false #1721

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 27, 2025
Merged

set hoist-workspace-packages=false #1721

merged 1 commit into from
Feb 27, 2025

Conversation

ef4
Copy link
Contributor

@ef4 ef4 commented Feb 27, 2025

This is part of the effort to harmonize the ember and glimmer monorepos.

We upgraded ember to use pnpm 10 to match this repo, but discovered that starting at pnpm 9, pnpm defaults to hoisting all workspace packages such that they are erroneously resolvable by all dependencies.

This setting is more strict and correct and avoids specific confusing problems in ember's build.

@ef4
set hoist-workspace-packages=false
3a4e8a3 
This is part of the effort to harmonize the ember and glimmer monorepos. 

We upgraded ember to use pnpm 10 to match this repo, but discovered that starting at pnpm 9, pnpm defaults to hoisting all workspace packages such that they are erroneously resolvable by *all* dependencies. 

This setting is more strict and correct and avoids specific confusing problems in ember's build.
@github-actions GitHub Actions
Copy link
Contributor

This PRmain
Dev 
583K └─┬ .
169K   ├── runtime
160K   ├── syntax
100K   ├── compiler
 58K   ├── opcode-compiler
 27K   ├── manager
 19K   ├── validator
 11K   ├── program
8.9K   ├── reference
7.2K   ├── destroyable
6.3K   ├── util
4.3K   ├── node
3.4K   ├── global-context
2.5K   ├── wire-format
1.0K   ├── vm
969B   ├── encoder
844B   ├── vm-babel-plugins
606B   └── owner

583K └─┬ .
169K   ├── runtime
160K   ├── syntax
100K   ├── compiler
 58K   ├── opcode-compiler
 27K   ├── manager
 19K   ├── validator
 11K   ├── program
8.9K   ├── reference
7.2K   ├── destroyable
6.3K   ├── util
4.3K   ├── node
3.4K   ├── global-context
2.5K   ├── wire-format
1.0K   ├── vm
969B   ├── encoder
844B   ├── vm-babel-plugins
606B   └── owner
Prod 
230K └─┬ .
 70K   ├── syntax
 63K   ├── runtime
 48K   ├── compiler
 18K   ├── opcode-compiler
7.9K   ├── manager
4.8K   ├── program
4.0K   ├── validator
3.6K   ├── reference
2.4K   ├── util
2.1K   ├── node
1.6K   ├── wire-format
1.5K   ├── destroyable
737B   ├── vm
594B   ├── global-context
516B   ├── encoder
469B   ├── vm-babel-plugins
155B   └── owner

230K └─┬ .
 70K   ├── syntax
 63K   ├── runtime
 48K   ├── compiler
 18K   ├── opcode-compiler
7.9K   ├── manager
4.8K   ├── program
4.0K   ├── validator
3.6K   ├── reference
2.4K   ├── util
2.1K   ├── node
1.6K   ├── wire-format
1.5K   ├── destroyable
737B   ├── vm
594B   ├── global-context
516B   ├── encoder
469B   ├── vm-babel-plugins
155B   └── owner

@NullVoxPopuli NullVoxPopuli merged commit e9bd081 into main Feb 27, 2025
10 of 11 checks passed
@NullVoxPopuli NullVoxPopuli deleted the hoist-workspace-packages-false branch February 27, 2025 21:33
@github-actions github-actions bot mentioned this pull request Feb 27, 2025
Merged
@NullVoxPopuli NullVoxPopuli mentioned this pull request Mar 4, 2025
Merged
@github-actions github-actions bot mentioned this pull request Mar 4, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NullVoxPopuli NullVoxPopuli NullVoxPopuli approved these changes

Assignees
No one assigned
Labels
internal
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ef4 @NullVoxPopuli